Silverlight Controls and Silverlight Toolkit

Re: Re: Re: Bug: Default DatePicker Template

Yi-Lun Luo - MSFT — Fri, 18 Jul 2008 03:56:28 GMT

There's a concept called name scope. With in a scope, each name must be unique. But you can have same names in different scopes. Please refer to http://msdn.microsoft.com/en-us/library/ms746659.aspx. Basically, each ControlTemplate has a name scope. In the above sample, the first DisabledVisual is in the ControlTemplate of DropDownButtonTemplate, while the second is in the ControlTemplate of the DatePicker. They're in different ControlTemplates, so they're in different name scopes, and thus the names can be the same.

Re: Re: Bug: Default DatePicker Template

GuptaAtul — Thu, 17 Jul 2008 13:25:29 GMT

Thanks again and one final query before we can close this. Isn't there a need to have the x:Name values unique in a XAML as mentioned here - http://msdn.microsoft.com/en-us/library/ms752290.aspx?

In the template you have mentioned above, there are two rectangles with the same x:Name as DisabledVisual?

Re: Re: Bug: Default DatePicker Template

Yi-Lun Luo - MSFT — Thu, 17 Jul 2008 11:34:12 GMT

The document is a bit different from the real template. If you use Reflect to view the actual ControlTemplate for DatePicker, you'll see this:

<ControlTemplate x:Key="DropDownButtonTemplate" TargetType="Button">
                                <Grid>
                                    <Grid.Resources>
                                        
                                        <Color x:Key="BaseColor">#FF003255</Color>
                                        <Color x:Key="LinearBevelLightStartColor">#FCFFFFFF</Color>
                                        <Color x:Key="LinearBevelLightEndColor">#F4FFFFFF</Color>
                                        <Color x:Key="LinearBevelDarkStartColor">#E0FFFFFF</Color>
                                        <Color x:Key="LinearBevelDarkEndColor">#B2FFFFFF</Color>
                                        <Color x:Key="MouseOverLinearBevelDarkEndColor">#7FFFFFFF</Color>
                                        <Color x:Key="HoverLinearBevelLightStartColor">#FCFFFFFF</Color>
                                        <Color x:Key="HoverLinearBevelLightEndColor">#EAFFFFFF</Color>
                                        <Color x:Key="HoverLinearBevelDarkStartColor">#D8FFFFFF</Color>
                                        <Color x:Key="HoverLinearBevelDarkEndColor">#4CFFFFFF</Color>
                                        <Color x:Key="CurvedBevelFillStartColor">#B3FFFFFF</Color>
                                        <Color x:Key="CurvedBevelFillEndColor">#3CFFFFFF</Color>
                                        <SolidColorBrush x:Key="BorderBrush" Color="#FF000000" />
                                        <SolidColorBrush x:Key="IconColor" Color="#FF000000" />
                                        <SolidColorBrush x:Key="AccentBrush" Color="#FFFFFFFF" />
                                        <SolidColorBrush x:Key="DisabledBrush" Color="#A5FFFFFF" />
                                    </Grid.Resources>
                                    <vsm:VisualStateManager.VisualStateGroups>
                                        <vsm:VisualStateGroup x:Name="CommonStates">
                                            <vsm:VisualStateGroup.Transitions>
                                                <vsm:VisualTransition Duration="0" />
                                                <vsm:VisualTransition To="MouseOver" Duration="0:0:0.2" />
                                                <vsm:VisualTransition To="Pressed" Duration="0:0:0.1" />
                                            </vsm:VisualStateGroup.Transitions>
                                            <vsm:VisualState x:Name="Normal" />
                                            <vsm:VisualState x:Name="MouseOver">
                                                <Storyboard>
                                                    <ColorAnimation Storyboard.TargetName="LinearBevelDarkEnd" Storyboard.TargetProperty="Color" To="{StaticResource MouseOverLinearBevelDarkEndColor}" Duration="0" />
                                                </Storyboard>
                                            </vsm:VisualState>
                                            <vsm:VisualState x:Name="Pressed">
                                                <Storyboard>
                                                    <DoubleAnimation Storyboard.TargetName="LinearBevelLightEnd" Storyboard.TargetProperty="Offset" To=".2" Duration="0" />
                                                    <ColorAnimation Storyboard.TargetName="LinearBevelLightStart" Storyboard.TargetProperty="Color" To="{StaticResource HoverLinearBevelLightEndColor}" Duration="0" />
                                                    <ColorAnimation Storyboard.TargetName="LinearBevelLightEnd" Storyboard.TargetProperty="Color" To="{StaticResource HoverLinearBevelLightEndColor}" Duration="0" />
                                                    <ColorAnimation Storyboard.TargetName="LinearBevelDarkStart" Storyboard.TargetProperty="Color" To="{StaticResource HoverLinearBevelDarkStartColor}" Duration="0" />
                                                    <ColorAnimation Storyboard.TargetName="LinearBevelDarkEnd" Storyboard.TargetProperty="Color" To="{StaticResource HoverLinearBevelDarkEndColor}" Duration="0" />
                                                    <DoubleAnimation Storyboard.TargetName="DownStroke" Storyboard.TargetProperty="Opacity" To="1" Duration="0" />
                                                </Storyboard>
                                            </vsm:VisualState>
                                            <vsm:VisualState x:Name="Disabled">
                                                <Storyboard>
                                                    <DoubleAnimation Storyboard.TargetName="DisabledVisual" Storyboard.TargetProperty="Opacity" To="1" Duration="0" />
                                                </Storyboard>
                                            </vsm:VisualState>
                                        </vsm:VisualStateGroup>
                                    </vsm:VisualStateManager.VisualStateGroups>

            </Setter.Value>
        </Setter>
    </Style>

There's no Rectangle named Disabled. But even there is, it should not cause problem at runtime. Visual States have their own name scope. Currently there're some problem regarding the vsm prefix which will be fixed in a future build.

Re: Bug: Default DatePicker Template

GuptaAtul — Wed, 16 Jul 2008 13:07:51 GMT

There is another rectangle with that name, i have pasted a snippet from the template below and bold faced the two rectangles. The one where i faced the error and other which is already called as DisabledVisual

<Rectangle x:Name="Disabled" RadiusX="2" RadiusY="2" Fill="{StaticResource DisabledBrush}" Opacity="0" />
                            </Grid>
                        </ControlTemplate>
                        <Storyboard Name="Normal State"/>
                        <Storyboard Name="Disabled State">
                            <DoubleAnimation Duration="0:0:0.2" Storyboard.TargetName="DisabledVisual" Storyboard.TargetProperty="Opacity" To="1"/>
                        </Storyboard>
                    </Grid.Resources>
                    <Grid.ColumnDefinitions>
                        <ColumnDefinition Width="*"/>
                        <ColumnDefinition Width="Auto"/>
                    </Grid.ColumnDefinitions>
                    <Grid.RowDefinitions>
                        <RowDefinition Height="Auto"/>
                    </Grid.RowDefinitions>
                    
                    <local:DatePickerTextBox x:Name="TextBox" Width="{TemplateBinding Width}" Grid.Column="0" Padding="5,4,6,3"/>
                    <Button x:Name="Button" Template="{StaticResource DropDownButtonTemplate}" Grid.Column="1" Width="20.5" Margin="-21,0,0,0"/>
                    <Rectangle x:Name="DisabledVisual" Grid.ColumnSpan="2" Fill="{StaticResource DisabledBrush}" Opacity="1" Visibility="Visible"/>

Re: Bug: Default DatePicker Template

Yi-Lun Luo - MSFT — Mon, 14 Jul 2008 11:26:02 GMT

Hello, I believe this is a document error. In the real template, the Rectangle's name is DisabledVisual.

Bug: Default DatePicker Template

GuptaAtul — Thu, 10 Jul 2008 09:05:26 GMT

I took the DatePicker control template from MSDN (http://msdn.microsoft.com/en-us/library/cc278067(VS.95).aspx). However when I use it as a style for DatePicker control in my code and run the application, I get a System.Stack.OverflowException.

<System_Windows_Controls:DatePicker HorizontalAlignment="Left" VerticalAlignment="Top" Style="{StaticResource newDatePickerStyle}"/>

And the newDatePickerStyle is as obtained from msdn. If I open the XAML in Blend, it points out the error saying that the name "Disabled" has been used twice. When I checked the XAML, I found out that it is being used for a Rectangle and for one of states managed by VSM.

<vsm:VisualState x:Name="Disabled">

</Storyboard>

</vsm:VisualState>

and

I changed the name for Rectangle to rDisabled, and it worked fine after that. Surprisingly, this error isn't shown at design time in VS, but only in Blend. There are few other errors shown in VS at design time, but somehow they dont' cause issue at runtime.